Docstring fix. #9569
Merged
Docstring fix. #9569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstansby
reviewed
Oct 25, 2017
| @@ -2644,23 +2644,19 @@ class FigureManagerBase(object): | ||
| num : int or str | ||
| The figure number | ||
|
|
||
| key_press_handler_id : int |
There was a problem hiding this comment.
Shouldn't this whole bit of docstring be under __init__ below? I don't think either place is right for key_press_handler_id anyway, since neither method takes that as a parameter.
There was a problem hiding this comment.
It's documented as a class attribute, not as a constructor parameter.
dstansby
approved these changes
Oct 25, 2017
dopplershift
added a commit
that referenced
this pull request
Oct 25, 2017
Backport PR #9569 on branch v2.1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just moving a comment into a docstring.
PR Summary
PR Checklist