Fix stale draws on MacOSX backend #9549
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This took awhile to understand and I thought I was going nuts trying to get OSX Core Graphics to clear a rectangle. It turns out the stale drawing was coming from Agg itself. After comparing against Qt5Agg, it turns out that before this PR, MacOSX never called
get_renderer
withcleared=True
, which causes the Agg renderer to clear its buffer; it only happened on resize/dpi change. With this patch, we now pass the stale flag as the value forcleared
.Fixes #8282.
It also turns out that
get_renderer
was a complete copy of what's inFigureCanvasAgg
, so I just nuked the method inFigureCanvasMac
.Testing was accomplished with a slight modification of the code from #8282:
Before this patch, you get a diamond-shaped plot and titles overlaid. After, the whole plot changes between subsequent draws.