Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

DOC Added the colormap references back #9530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2017
Merged

DOC Added the colormap references back #9530

merged 1 commit into from
Oct 23, 2017

Conversation

NelleV
Copy link
Member

@NelleV NelleV commented Oct 22, 2017

For fast access. The user should not have to go to the tutorials to get the list of available colormaps.

@anntzer
Copy link
Contributor

anntzer commented Oct 22, 2017

EDITED: I agree that a shorter description of all colormaps is necessary; I guess the examples is as good a place as any other to put them.

It would definitely be useful to add a link from http://matplotlib.org/api/cm_api.html (at the top) to this example.

@choldgraf
Copy link
Contributor

+1 on adding to examples, I think it's a more quickly-discoverable place for this kind of info. Also +1 on generally cross-linking as much as possible


gives a list of RGB colors that are good for plotting a series of lines on
a dark background.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth adding a section (maybe in another PR?) that lists all colorblind-friendly colormaps?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm all for that/think that's a great idea.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should be added to this example. This is a reference list. This should be (if it isn't already) in the colormap tutorial.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why shouldn't a reference list provide accessibility references?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be handled by including a reference here to the tutorial section?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, so long as there's an explicit mention of colorblind maps, something "See the tutorial for a more detailed explanation of colormaps, including information on colorblind friendly"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just delete all the text (it's a reference!) and replace it by "for an in-depth overview of colomaps, including discussion about colorblind-friendliness, see (tutorial)".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no information on colorblind maps in the tutorial, just outside references.

Feel free to merge or close if you feel this is not an improvement to the documentation.

Copy link
Member

@efiring efiring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting this back is good; I recently had to hunt for it.

I think the description of qualitative colormaps is misleading, but perhaps fixing that is best left to a separate PR.

@NelleV
Copy link
Member Author

NelleV commented Oct 22, 2017

I didn't write it. This is just the old example (which is by the way still hanging around in the website, from an old build, and links misleading to some old hidden references and documentation).

The text and documentation can definitely be improved, but I don't have time to do this.

@anntzer
Copy link
Contributor

anntzer commented Oct 23, 2017

I think it's clearly an improvement, if @NelleV doesn't want to make further edits, further fixes can go to a separate PR.

@anntzer anntzer merged commit b263f40 into matplotlib:master Oct 23, 2017
@tacaswell tacaswell added this to the v2.1.0-doc milestone Oct 23, 2017
@tacaswell
Copy link
Member

@meeksdev backport to v2.1.0-doc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.