Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@QuLogic
Copy link
Member

@QuLogic QuLogic commented Oct 17, 2017

PR Summary

master broke when a new next what's new entry was added.

PR Checklist

  • [N/A] Has Pytest style unit tests
  • [N/A] Code is PEP 8 compliant
  • [N/A] New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [N/A] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@QuLogic QuLogic added this to the v2.2 milestone Oct 17, 2017
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, particularly if it now lets the docs get built w/o the "whats new" error...

@QuLogic
Copy link
Member Author

QuLogic commented Oct 18, 2017

Merging because this doesn't really require tests and doc builds are broken.

@QuLogic QuLogic merged commit d7ddd47 into matplotlib:master Oct 18, 2017
@QuLogic QuLogic deleted the next-whats-new branch October 18, 2017 05:39
@tacaswell
Copy link
Member

Thanks @QuLogic !

@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.