Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Minor fixes to gallery build. #9424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2017
Merged

Minor fixes to gallery build. #9424

merged 1 commit into from
Oct 16, 2017

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Oct 16, 2017

  1. Do not call matplotlib.use("svg") in the svg-specific examples, as
    this is unneeded (matplotlib will internally switch the canvas at save
    time) and triggers a warning because s-g already set the canvas to agg.

  2. Do not report computation times for examples than ran faster than 1s
    (i.e., most of them) -- for fast examples, we are timing and reporting
    noise.

  3. Some markup fixes.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

1. Do not call `matplotlib.use("svg")` in the svg-specific examples, as
this is unneeded (matplotlib will internally switch the canvas at save
time) and triggers a warning because s-g already set the canvas to agg.

2. Do not report computation times for examples than ran faster than 1s
(i.e., most of them) -- for fast examples, we are timing and reporting
noise.

3. Some markup fixes.
@phobson phobson merged commit 22cb2d4 into matplotlib:master Oct 16, 2017
@anntzer anntzer deleted the sg-fixes branch October 16, 2017 16:49
@QuLogic QuLogic added this to the v2.2 milestone Oct 16, 2017
@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.