Fix documents of semilogx and semilogy. #9268
Conversation
lib/matplotlib/axes/_axes.py
Outdated
| **kwargs : | ||
| Keyword arguments control the :class:`~matplotlib.lines.Line2D` | ||
| properties: | ||
| **kwargs : Keyword arguments control the :class:`~matplotlib.lines.Line2D` properties: |
There was a problem hiding this comment.
Please keep the description on its own line (only type information should really be on the same line).
| @@ -1631,7 +1629,8 @@ def semilogx(self, *args, **kwargs): | ||
| # @_preprocess_data() # let 'plot' do the unpacking.. | ||
| @docstring.dedent_interpd | ||
| def semilogy(self, *args, **kwargs): | ||
| r"""Make a plot with log scaling on the `y` axis. | ||
| """ |
There was a problem hiding this comment.
Although not crucial, it would be nice to take advantage of this opportunity to fix the docstring of semilogy to exactly match the one of semilogx, save for x/y. Right now there are a number of discrepancies.
There was a problem hiding this comment.
I have already fixed the docstring of semilogy to match the one of semilogx.
9de5a19 to
8a8ceaf
Compare
|
... did you undo most of your work? |
|
No, I didn't undo most of my work, I just updated semilogy to make it match semilogx. |
|
Sorry, I misunderstood you. I also changed the Parameter part of semilogy this time to exactly match semilogx. |
Backport PR #9268 on branch v2.1.x
|
@skx19952 I think this was your first MPL PR? Congratulations 🎉 Hopefully we will hear from you again. |
PR Checklist