Convert test images from svg to svgz #9214
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conversion was done with
(svgz is literally gzip'ed svg)
and manual fixes to the tests (in a separate commit).
The global size of all test svgs was 15Mb; it is 4Mb after compression.
Obviously that won't help with objects stuck in the git repository; instead, the main advantage is to make future addition of more svgs less problematic (the largest objects in the git repo are some svgs >5Mb (that have been deleted but are stuck in the history forever)), and also to prevent Github from showing svgs in the PR diff interface (although the later can also be achieved using gitattributes).
Alternative (or complementary to) #9215.
EDIT: Actually git appears to zlib-compress its objects (https://matthew-brett.github.io/curious-git/reading_git_objects.html) so this PR may not be that helpful wrt repo size...
PR Summary
PR Checklist