Add a banner indicating docs are unreleased. #9003
Conversation
|
https://426-1385122-gh.circle-artifacts.com/0/home/circleci/project/doc/build/html/index.html The black on red is a bit hard to read. |
|
Agreed. Switch to a lighter red, or a lighter font.
…On Mon, Aug 7, 2017 at 3:43 PM, Thomas A Caswell ***@***.***> wrote:
https://426-1385122-gh.circle-artifacts.com/0/home/circleci/
project/doc/build/html/index.html
The black on red is a bit hard to read.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#9003 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AARy-NgfcDKjnSn6dTOc2IgL9HcGQuu1ks5sV2jTgaJpZM4OvG1v>
.
|
|
Ah yes, I should have checked the colours after bolding it all. How about just plain white? |
|
Looks much better to me.
…On Mon, Aug 7, 2017 at 4:26 PM, Elliott Sales de Andrade < ***@***.***> wrote:
Ah yes, I should have checked the colours after bolding it all. How about
just plain white?
[image: screen shot 2017-08-07 at 16 24 00]
<https://user-images.githubusercontent.com/302469/29044318-e6565b44-7b8c-11e7-89c9-f30d2fbf6f91.png>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#9003 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AARy-MNIrROlyB36DOG-XGK_WGoEKgnDks5sV3LogaJpZM4OvG1v>
.
|
4d42fde to
4702395
Compare
|
Why is the second sentence a question linked to a search, instead of a simple link to the released docs? |
|
This banner would appear on any unreleased page, and so there won't
necessarially be a 1-to-1 map between the page you landed on and a page in
the released documentation. So, it makes some sense to provide that as a
suggestion.
…On Mon, Aug 7, 2017 at 4:47 PM, Eric Firing ***@***.***> wrote:
Why is the second sentence a question linked to a search, instead of a
simple link to the released docs?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#9003 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AARy-C_o7mFzf7eB2cPH4aVZIHkKB7-2ks5sV3f8gaJpZM4OvG1v>
.
|
|
Only comment is to remove the text shadow and to highlight the link with an underline instead. The text shadow makes the text a bit tricky to read, while an underline is a more universal convention for identifying links. Otherwise, the fixed header works really well |
4702395 to
383e0f1
Compare
|
Just a heads up – this text-decoration syntax isn't well supported across browsers (http://caniuse.com/#feat=text-decoration). I'd advise either removing the "dotted" attribute altogether or breaking the CSS to |
Also, point to a search for the same page in the latest released version. Unfortunately, there's no easy way to point to the exact same page, especially with all the moved pages.
383e0f1 to
65ceda8
Compare
There was a problem hiding this comment.
Latest built docs can be found here: https://466-1385122-gh.circle-artifacts.com/0/home/circleci/project/doc/build/html/gallery/index.html
|
bah, accidentally squash-merged that. Thanks everyone! |
We've been getting quite a lot of tickets asking about features that don't yet exist in the released versions, so add a banner indicating that the page is for the unreleased version. I chose to use tab10:red + bolding, which I hope is flashy enough to catch people's attention.
Also, point to a search for the same page in the latest released version. Unfortunately, there's no easy way to point to the exact same page, especially with all the moved examples lately.
cc @doraf