Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Don't pretend to support Google App Engine. #8939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2017

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jul 25, 2017

It's broken further down anyways: see discussion starting at
https://gitter.im/matplotlib/matplotlib?at=59777c5e1c8697534a5be4cb xref #8932

If we want to restore this functionality it should be correctly tested.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/whats_new.rst if major new feature
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

It's broken further down anyways: see discussion starting at
https://gitter.im/matplotlib/matplotlib?at=59777c5e1c8697534a5be4cb

If we want to restore this functionality it should be correctly tested.
@tacaswell
Copy link
Member

huh, GAE has a whole doc section on us: https://cloud.google.com/appengine/docs/standard/python/tools/using-libraries-python-27#matplotlib however, they ship 1.2.0 (!?) https://cloud.google.com/appengine/docs/standard/python/tools/built-in-libraries-27

I am mixed on this. Last time this got fixed a google engineer did the work. A few release ago I did ping them about updating, but it apparently involves a through security review (!). If we have already broken it, ripping out all of the special cases and waiting for google to fix it again is probably a reasonable path.

@tacaswell tacaswell added this to the 2.1 (next point release) milestone Jul 25, 2017
@anntzer
Copy link
Contributor Author

anntzer commented Jul 26, 2017

I would say unless the GAE team is free to patch mpl in whatever way they want or even make a new PR which makes mpl 2.0+ work once again in GAE (possibly with testing this time...), but right now the code is basically useless.

@tacaswell
Copy link
Member

If google wants to update the version of Matplotlib they ship, this will probably be small to fix compared to the rest of the work they will need to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.