Fix Appveyor build. #8334
Merged
Fix Appveyor build. #8334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
635e2ab to
6e18e57
Compare
|
attn @tacaswell |
Recent condas prefer (by default) packages in higher priority channels to packages in lower priority channels regardless of their versions. conda-forge sometimes serves older condas than the official repos, so we need to put it at the end to avoid accidentally downgrading conda. Do not depend on the user name to construct a temporary cache directory when needed, as e.g. conda-build hides the required environment variable (`%USERNAME%`) on Windows. Simplify implementation of `matplotlib_fname`.
6e18e57 to
0140c84
Compare
NelleV
reviewed
Mar 19, 2017
| - cmd: conda config --add channels conda-forge | ||
| # conda-forge may serve outdated versions of certain packages (e.g. conda | ||
| # itself), so append it to the end of the list. | ||
| - cmd: conda config --append channels conda-forge |
There was a problem hiding this comment.
- Right now conda-forge is serving an outdated version of conda which is the reason the Appveyor build broke. I would hope that the official conda channel never serves an outdated version of conda... I don't think serving outdated versions of other build dependencies is as much of an issue (if any).
- I could instead set the
channel_priorityoption documented at https://conda.io/docs/channels.html#managing-conda-channels, but there are other issues with that (see the link). I don't have a strong opinion though.
There was a problem hiding this comment.
conda-build 2.1.7 has now been released on conda-forge for windows py2.7.
There was a problem hiding this comment.
looks like this is not enough, I guess we also need a more recent version of conda itself (I guess what happens is that a recent conda-build exposes a bug in an old version of conda), see latest appveyor builds which fail with conda 4.2.13+conda-build 2.1.7 (vs my PR which uses 4.3.14/2.1.7)
phobson
approved these changes
Mar 23, 2017
|
I'd leave that as a separate issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent condas prefer (by default) packages in higher priority channels
to packages in lower priority channels regardless of their versions.
conda-forge sometimes serves older condas than the official repos, so we
need to put it at the end to avoid accidentally downgrading conda.
Do not depend on the user name to construct a temporary cache directory
when needed, as e.g. conda-build hides the required environment variable
(
%USERNAME%) on Windows.