DOC: missing API docs from #8032 #8285
Next
Next commit
DOC: missing API docs from #8032
- Loading branch information
commit b16705d0d12f5ca39dd3d509472e01ef249ceec9
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| Do not clip lw when scaling dashes | ||
| `````````````````````````````````` | ||
|
|
||
| Slightly change the algorithm to no longer clip the scaling factor, | ||
| thus the patterns will continue to shrink at thin line widths. If the | ||
| line width is smaller than the effective pixel size, this may result | ||
| in dashed lines turning into solid gray lines. This also required | ||
| slightly tweaking the default patterns for '--', ':', and '.-' so that | ||
| with the default line-width the final patterns would not change. | ||
|
There was a problem hiding this comment. line-width <- line width? (to be consistent with the other utterances of the expression). Beside, it is not totally true that the new default patterns are exactly the same as before (e.g. the dotted pattern that is not a 50 %-50 % pattern anymore). Maybe the sentence should just state that the default patterns were tweaked to remain similar with the default lw value as well as to avoid “cluttering” with line widths thiner than the previous clipping boundary. |
||
|
|
||
| There is no way to restore the old behavior | ||
|
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why gray?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The line was implicitly black in my head when I wrote this.