-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Early check for dot binary (from graphviz) when building the doc (fixes #8207) #8221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good if tests pass!
It also look good to me, though the amount of dependencies we have in our documentation worries me. It means that new contributors struggle with something as simple as contributing documentation. |
@NelleV I wonder whether we could create two mpl-testing and mpl-docs packages on conda-forge which would pull in all required dependencies, including the non-python ones (for example, graphviz is packaged by conda). Then the instructions would just be to install the corresponding package from conda. |
@anntzer I don't use conda, so I have no opinion on whether this would be useful. An option would be to change the default for allowsphinxwarnings so that people can build the documentation with missing dependencies. That would reduce the barrier for contributions, but then it would be up to us (core contributors) to guide new contributors on fixing travis build. I do not think we are well equipped for that option. |
Alternatively, I know that imageio has been including code to download ffmpeg/avbin/freeimage at runtime (http://imageio.readthedocs.io/en/latest/envvariables.html), so that could be an option too (although it would certainly have its own issues, unless they have completely statically linked builds...). |
Thanks @afvincent ! |
Early check for dot binary (from graphviz) when building the doc (fixes #8207)
Backported to |
Fixes #8207.
The commit is shamelessly inspired from #8213.