Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Clean up and move accented text example #8065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 23, 2017

Conversation

dstansby
Copy link
Member

I thought I'd kick off the docathon by moving and cleaning the first example in pylab_examples.


Matplotlib supports accented characters via TeX mathtext.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also supported through regular Unicode characters, though that's not shown here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am 👍 on making this file utf-8 encoded and adding some accented characters.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps merge it with unicode_demo.py then? See also #8083.

@NelleV NelleV added this to the 2.1 (next point release) milestone Feb 16, 2017
Copy link
Member

@NelleV NelleV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@NelleV NelleV changed the title Clean up and move accented text example [MRG+1] Clean up and move accented text example Feb 16, 2017
Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(marking a change request so that the option of merging with unicode_demo.py is more visible -- especially given the overlap with #8083. @dstansby feel free dismiss this review if you don't plan to do so, but then you get to take care of #8083 :-))

@dstansby
Copy link
Member Author

👍 done.

nb. I am just ignoring backend_driver for now, since one of my other PRs will get rid of needing to specify tests one by one and manually keeping track of them.

ax.set_title(r'$\ddot{o}\acute{e}\grave{e}\hat{O}'
r'\breve{i}\bar{A}\tilde{n}\vec{q}$', fontsize=20)

# Shorthand is also supported and curly's are optional
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"curlies" perhaps?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

attn @dstansby

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curly braces?

# Unicode demo
fig, ax = plt.subplots()
ax.set_title('Développés et fabriqués')
ax.set_xlabel("réactivité nous permettent d'être sélectionnés et adoptés")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually both French sentences are meaningless. If we want to keep some foreign languages, I can propose

GISCARD CHAHUTÉ À L'ASSEMBLÉE
LE COUP DE DÉ DE DE GAULLE

(famous examples where keeping accents on caps is needed for the sentence to make any sense) :-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buffalo buffalo buffalo buffalo ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess English would benefit from diacritics too...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestions!

@QuLogic QuLogic merged commit a34c859 into matplotlib:master Feb 23, 2017
@QuLogic QuLogic changed the title [MRG+1] Clean up and move accented text example Clean up and move accented text example Feb 23, 2017
@anntzer anntzer mentioned this pull request Feb 26, 2017
16 tasks
@dstansby dstansby deleted the doc-accented-text branch April 2, 2017 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.