Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Reject floatlike strings in mcolors.to_rgba. #7896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2017
Merged

Reject floatlike strings in mcolors.to_rgba. #7896

merged 1 commit into from
Jan 22, 2017

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 20, 2017

Fixes the regression noted in #7891.

@anntzer anntzer mentioned this pull request Jan 20, 2017
Closed
@anntzer anntzer force-pushed the to_rgba-reject-floatlike-strings branch from b55f226 to 4ba9330 Compare January 20, 2017 19:26
efiring
efiring approved these changes Jan 20, 2017
View reviewed changes
Copy link
Member

@efiring efiring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@anntzer anntzer force-pushed the to_rgba-reject-floatlike-strings branch from 4ba9330 to 0cad64f Compare January 20, 2017 21:56
@anntzer
Copy link
Contributor Author

anntzer commented Jan 20, 2017

Needed a fix...

@NelleV NelleV merged commit 12ec2c1 into matplotlib:master Jan 22, 2017
@NelleV
Copy link
Member

NelleV commented Jan 22, 2017

Thanks @anntzer

@NelleV
Copy link
Member

NelleV commented Jan 22, 2017

backported to v2.0.x as 1c752f7

@anntzer anntzer deleted the to_rgba-reject-floatlike-strings branch January 22, 2017 20:51
@QuLogic QuLogic added this to the 2.0.1 (next bug fix release) milestone Jan 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efiring efiring efiring approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.1
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @NelleV @efiring @QuLogic
Morty Proxy This is a proxified and sanitized view of the page, visit original site.