Fixed bug with default parameters NFFT and noverlap ins specgram()

matplotlib · efiring · Jan 17, 2017 · Jan 16, 2017 · Jan 16, 2017 · Jan 16, 2017
commit 70551ecb3f9facae23a847dab302c9fc86f99952
diff --git a/lib/matplotlib/axes/_axes.py b/lib/matplotlib/axes/_axes.py
@@ -7234,6 +7234,11 @@ def specgram(self, x, NFFT=None, Fs=None, Fc=None, detrend=None,
        Z = np.flipud(Z)

        if xextent is None:
+            # define default values:
+            if noverlap is None:
+                noverlap = 128  # defined in mlab.specgram
+            if NFFT is None:
+                NFFT = 256  # defined in mlab._spectral_helper
            # padding is needed for first and last segment:
            pad_xextent = (NFFT-noverlap) / Fs / 2
            xextent = np.min(t) - pad_xextent, np.max(t) + pad_xextent
-Original file line number
+Diff line change
@@ -7234,6 +7234,11 @@ def specgram(self, x, NFFT=None, Fs=None, Fc=None, detrend=None,
             Z = np.flipud(Z)
             if xextent is None:
+                # define default values:
             Copy link

  
      
    
  

  
      

  
  Member


      

  

  
    
      

      
            tacaswell
  

      

      

      


        Jan 16, 2017


      
    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      Can you move this up to the top?  I think it is better to have this over-ride the defaults if we change the defaults in mlab.specgram than to have this silently get out of sync (it is unlikely we will make that change, but this just smell very brittle to me).
    
  
  


    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
      
  
    
    
      
        
            
    All reactions
+                if noverlap is None:
+                    noverlap = 128  # defined in mlab.specgram
+                if NFFT is None:
+                    NFFT = 256  # defined in mlab._spectral_helper
                 # padding is needed for first and last segment:
                 pad_xextent = (NFFT-noverlap) / Fs / 2
                 xextent = np.min(t) - pad_xextent, np.max(t) + pad_xextent
-          Expand Down