MAINT added early checks for dependencies for doc building #7828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NelleV Why can't you build the docs? |
tacaswell
approved these changes
Jan 14, 2017
|
Because a new module was added, and the setup.py was not updated. I am fixing this right now and creating a new pull requests, but I am taking this opportunity to do a bit of cleaning up. |
|
It turns out that my code was just too old. I did start a bit of refactoring so I am going to finish this up, but I'll be able to tests the documentation building again soon. |
|
So… On a fresh conda environments, it seems that this patch checks for all early dependencies on linux. |
Current coverage is 62.09% (diff: 100%)@@ master #7828 diff @@
==========================================
Files 174 174
Lines 56052 56052
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 34809 34807 -2
- Misses 21243 21245 +2
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch addresses at least partially #7793 by adding an early check on the presence of pillow's dependencies. It avoids the documentation to fail building after 20 minutes.
I was not able to build the documentation at this point and am thus unable to confirm that all dependencies are checked for early on.