Raise exception if negative height or width is passed to axes() #7783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
reviewed
Jan 10, 2017
| @@ -483,6 +483,9 @@ def __init__(self, fig, rect, | ||
| self._position = rect | ||
| else: | ||
| self._position = mtransforms.Bbox.from_bounds(*rect) | ||
| x0, y0, x1, y1 = self._position.extents | ||
| if ((x1 - x0) < 0 or (y1 - y0) < 0): |
There was a problem hiding this comment.
You can use self._position.width < 0 or self._position.height < 0.
There was a problem hiding this comment.
Thanks for the tip!
anntzer
reviewed
Jan 11, 2017
| @@ -483,6 +483,8 @@ def __init__(self, fig, rect, | ||
| self._position = rect | ||
| else: | ||
| self._position = mtransforms.Bbox.from_bounds(*rect) | ||
| if self._position.width < 0 or self._position.height < 0: | ||
| raise ValueError('Height and width specified must be non-negative') |
There was a problem hiding this comment.
Very minor point: probably "Width and height must be non-negative" is better (as the order is x, y). I wouldn't add "specified" but I'll let a native speaker chime in :p
There was a problem hiding this comment.
I'm a native speaker ;p
There was a problem hiding this comment.
That's fine, the point about order still remains valid :p
There was a problem hiding this comment.
(I would suggest squashing the commits too.)
|
Commits squashed! |
Current coverage is 62.11% (diff: 50.00%)@@ master #7783 diff @@
==========================================
Files 174 174
Lines 56028 56030 +2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 34805 34804 -1
- Misses 21223 21226 +3
Partials 0 0
|
|
LGTM. |
dopplershift
approved these changes
Jan 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7487