DOC: fix py2 compatibility issue #7473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As this is fixing up a example which is failing travis, will self-merge as soon as it passes. |
|
I also get an error running the example directly with python2 due to the unicode emdash and no explicit source file encoding. |
2e305ba to
a0b44a7
Compare
|
Thank @QuLogic ! |
|
Grr, looks like it won't |
a0b44a7 to
5e1adca
Compare
|
Once more with feeling. |
- Turns out that maxsplit can only be used as a keyword arg in py3.3+ - use - instead of — to play nice with python2
5e1adca to
6a38195
Compare
|
lucky 4th force push. |
QuLogic
approved these changes
Nov 17, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that maxsplit can only be used as a keyword arg in py3.3+