Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Moved python files from doc/pyplots to examples folder #7398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 5, 2016
Merged

Moved python files from doc/pyplots to examples folder #7398

merged 4 commits into from
Nov 5, 2016

Conversation

wgranados
Copy link

Completed the first two changes specified in #7390 . When I was looking through the pyplots files with grep I didn't spot any places where the stdlib random module was used in stead of the numpy.random module.

moved python files from doc/pyplots to examples folder
7d64c41 
updated the dynamic links for doc/pyplots to examples/pyplots

fixed random state for reproducibility in pyplot examples
@tacaswell tacaswell added this to the 2.0.1 (next bug fix release) milestone Nov 3, 2016
@tacaswell tacaswell changed the title Moved python files from doc/pyplots to examples folder [MRG+1] Moved python files from doc/pyplots to examples folder Nov 3, 2016
tacaswell
tacaswell approved these changes Nov 3, 2016
View reviewed changes
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modulo the docs building cleanly on travis

@NelleV
Copy link
Member

NelleV commented Nov 4, 2016

That's great!
Thank you for doing this work.

@NelleV NelleV changed the title [MRG+1] Moved python files from doc/pyplots to examples folder [MRG+2] Moved python files from doc/pyplots to examples folder Nov 4, 2016
QuLogic
QuLogic reviewed Nov 4, 2016
View reviewed changes
doc/devel/documenting_mpl.rst
@@ -310,7 +310,7 @@ git. Please also add a line to the README in doc/pyplots for any additional
requirements necessary to generate a new figure. Once these steps have been
taken, these figures can be included in the usual way::

.. plot:: pyplots/tex_unicode_demo.py
.. plot:: mpl_examples/pyplots/tex_unicode_demo.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this and the section above is relevant any more? I don't see either README or make.py in the original doc/pyplots.

@NelleV
Copy link
Member

NelleV commented Nov 4, 2016

The failing tests are pep8 related error, which we probably don't want to fix in this PR…
If we merge, what's going to happen? How are the pep8 tests ran?

@QuLogic
Copy link
Member

QuLogic commented Nov 4, 2016

You can add those files to the list near the end of lib/matplotlib/tests/test_coding_standards.py to ignore the pep8 warnings for now.

added examples from pyplots to ignore list for pep8 coding standards
0543f77 
fixed typo from previous commit; redirected to wrong file path
@efiring
Copy link
Member

efiring commented Nov 5, 2016

Strangely, the pep8 checker doesn't ignore the excluded files, it checks to make sure they need to be excluded!

ValueError: Some exclude patterns were unnecessary as the files they pointed to either passed the PEP8 tests or do not point to a file:
  */pyplots/pyplot_scales.py
  */pyplots/pyplot_text.py
  */pyplots/pyplot_three.py
  */pyplots/whats_new_99_mplot3d.py

@NelleV
Copy link
Member

NelleV commented Nov 5, 2016

The strategy implemented on #7403 which runs flake8 on diffs fixes the issue we have on this PR.

Currently, there is a test that ensures that blacklisted files need to be blacklisted. Hence the new failure.

Merge pull request #1 from NelleV/wgma00_master
ce661b0 
FIX pep8 failed as some files are pep8 compliant
@NelleV NelleV merged commit 6709b59 into matplotlib:master Nov 5, 2016
NelleV added a commit that referenced this pull request Nov 5, 2016
@NelleV
Merge pull request #7398 from wgma00/master
263e675 
Moved python files from doc/pyplots to examples folder
@NelleV
Copy link
Member

NelleV commented Nov 5, 2016

Thanks @wgma00 for the patch!

Cherry-pick in 2.0 with 263e675

@QuLogic QuLogic changed the title [MRG+2] Moved python files from doc/pyplots to examples folder Moved python files from doc/pyplots to examples folder Nov 5, 2016
This was referenced Nov 5, 2016
Closed
Closed
@tacaswell
Copy link
Member

Complaining that an excluded file passes is a feature of the system to (slowly) ratchet our way to PEP8 compliance (so we do not accidentally fix a file and then break it again).

@QuLogic QuLogic modified the milestones: 2.0.1 (next bug fix release), 2.0 (style change major release) Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic left review comments

@NelleV NelleV NelleV approved these changes

@tacaswell tacaswell tacaswell approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@wgranados @NelleV @QuLogic @efiring @tacaswell
Morty Proxy This is a proxified and sanitized view of the page, visit original site.