Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Style typos fixes #7288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 17, 2016
Merged

Style typos fixes #7288

merged 3 commits into from
Oct 17, 2016

Conversation

mherkazandjian
Copy link
Contributor

No description provided.

NelleV
NelleV approved these changes Oct 17, 2016
View reviewed changes
Copy link
Member

@NelleV NelleV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch!

@NelleV NelleV changed the title Style typos fixes [MRG+1] Style typos fixes Oct 17, 2016
@anntzer
Copy link
Contributor

anntzer commented Oct 17, 2016

(A large chunk of these functions (dict_delall, reverse_dict, etc.) seem completely unused and are probably ripe for deprecation too...)

@mherkazandjian
Copy link
Contributor Author

yea, there is also some dead code!

QuLogic
QuLogic reviewed Oct 17, 2016
View reviewed changes
lib/matplotlib/cbook.py
@@ -1284,7 +1280,7 @@ def allpairs(x):
class maxdict(dict):
"""
A dictionary with a maximum size; this doesn't override all the
relevant methods to contrain size, just setitem, so use with
relevant methods to contain size, just setitem, so use with
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be constrain

@NelleV NelleV merged commit e24322c into matplotlib:master Oct 17, 2016
@NelleV
Copy link
Member

NelleV commented Oct 17, 2016

Thanks!

@QuLogic QuLogic added this to the 2.0.1 (next bug fix release) milestone Oct 18, 2016
QuLogic pushed a commit to QuLogic/matplotlib that referenced this pull request Oct 18, 2016
@NelleV @QuLogic
Merge pull request matplotlib#7288 from mherkazandjian/style_typos_fixes
723f889 
Style typos fixes
@QuLogic QuLogic changed the title [MRG+1] Style typos fixes Style typos fixes Oct 18, 2016
@QuLogic
Copy link
Member

QuLogic commented Oct 18, 2016

Backported to v2.x via 723f889.

@QuLogic QuLogic modified the milestones: 2.0.1 (next bug fix release), 2.0 (style change major release) Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic left review comments

@NelleV NelleV NelleV approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@mherkazandjian @anntzer @NelleV @QuLogic @mdboom
Morty Proxy This is a proxified and sanitized view of the page, visit original site.