Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

DOC improved subplots' docstring #7232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 13, 2016
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
DOC FIX axis -> x-axis in subplots
  • Loading branch information
NelleV committed Oct 13, 2016
commit a1e728206664d5202730d0700e6612b487665c4a
24 changes: 12 additions & 12 deletions 24 lib/matplotlib/figure.py
Original file line number Diff line number Diff line change
Expand Up @@ -1030,12 +1030,12 @@ def subplots(self, nrows=1, ncols=1, sharex=False, sharey=False,

sharex : {"none", "all", "row", "col"} or bool, default: False
- If True, the x-axis will be shared amongst all subplots.
- If False, no axis will be shared amongst subplots.
- If False, no x-axis will be shared amongst subplots.
- If a string must be one of "row", "col", "all", or "none".
- "all" has the same effect as True.
- "none" has the same effect as False.
- If "row", each subplot row will share a x-axis.
- If "col", each subplot column will share a x-axis.
- If "row", each subplot row will share an x-axis.
- If "col", each subplot column will share an x-axis.

Note that if the x-axis is shared across rows (sharex=True or
sharex="col"), then the x tick labels will only be display on
Expand All @@ -1048,26 +1048,26 @@ def subplots(self, nrows=1, ncols=1, sharex=False, sharey=False,
- "all" has the same effect as True.
- "none" has the same effect as False.
- If "row", each subplot row will share a y-axis.
- If "col", each subplot column will share a y-axis
- If "col", each subplot column will share an y-axis

Note that if the y-axis is shared across columns (sharey=False or
sharey="col"), 1 then the y tick labels will only be displayed on
Note that if the y-axis is shared across columns (sharey=True or
sharey="col"), then the y tick labels will only be displayed on
subplots of the first column.

squeeze : bool, default: True
- If True, extra dimensions are squeezed out from the returned
axis object:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'..the return object'


- if only one subplot is constructed (nrows=ncols=1), the
resulting single Axis object is returned as a scalar.
- for Nx1 or 1xN subplots, the returned object is a 1-d numpy
object array of Axis objects are returned as numpy 1-d
resulting single Axes object is returned as a scalar.
- for Nx1 or 1xN subplots, the returned object is a 1D numpy
object array of Axes objects are returned as numpy 1D
arrays.
Copy link
Contributor

@afvincent afvincent Oct 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there an extra verb in this sentence? Wouldn't be OK something like: 'for Nx1 or 1xN subplots, the returned object is a 1-d numpy object array of Axes instances'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NelleV I think you may have missed this one.

- for NxM subplots with N>1 and M>1 are returned as a 2d
- for NxM, subplots with N>1 and M>1 are returned as a 2D
arrays.
Copy link
Contributor

@afvincent afvincent Oct 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • '2-d array'?
  • Besides, I feel like some subject is missing (but my English may be wrong). I would have expected something like: 'for NxM subplots with N>1 and M>1, the returned object is a 2-d numpy object array of Axes instances.'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a comma is missing.


- If False, no squeezing at all is done: the returned axis object
is always a 2-d array containing Axis instances, even if it ends
- If False, no squeezing at all is done: the returned Axes object
is always a 2D array containing Axes instances, even if it ends
up being 1x1.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't all the 'Axis' in ll.1058-1071 be replaced with 'Axes'? matplotlib.axis.Axis is different from matplotlib.axes.Axes, isn't it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is a very important distinction!

subplot_kw : dict, default: {}
Expand Down
26 changes: 13 additions & 13 deletions 26 lib/matplotlib/pyplot.py
Original file line number Diff line number Diff line change
Expand Up @@ -1052,12 +1052,12 @@ def subplots(nrows=1, ncols=1, sharex=False, sharey=False, squeeze=True,

sharex : {"none", "all", "row", "col"} or bool, default: False
- If True, the x-axis will be shared amongst all subplots.
- If False, no axis will be shared amongst subplots.
- If False, no x-axis will be shared amongst subplots.
- If a string must be one of "row", "col", "all", or "none".
- "all" has the same effect as True.
- "none" has the same effect as False.
- If "row", each subplot row will share a x-axis.
- If "col", each subplot column will share a x-axis.
- If "row", each subplot row will share an x-axis.
- If "col", each subplot column will share an x-axis.

Note that if the x-axis is shared across rows (sharex=True or
sharex="col"), then the x tick labels will only be display on subplots
Expand All @@ -1070,24 +1070,24 @@ def subplots(nrows=1, ncols=1, sharex=False, sharey=False, squeeze=True,
- "all" has the same effect as True.
- "none" has the same effect as False.
- If "row", each subplot row will share a y-axis.
- If "col", each subplot column will share a y-axis
- If "col", each subplot column will share an y-axis

Note that if the y-axis is shared across columns (sharey=False or
sharey="col"), 1 then the y tick labels will only be displayed on
Note that if the y-axis is shared across columns (sharey=True or
sharey="col"), then the y tick labels will only be displayed on
subplots of the first column.

squeeze : bool, optional, default: True
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is an indentation problem around here, but I can't see it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found the problem and fixed it.

- If True, extra dimensions are squeezed out from the returned axis
- If True, extra dimensions are squeezed out from the returned Axes
object:

- if only one subplot is constructed (nrows=ncols=1), the
resulting single Axis object is returned as a scalar.
- for Nx1 or 1xN subplots, the returned object is a 1-d numpy
object array of Axis objects are returned as numpy 1-d arrays.
- for NxM subplots with N>1 and M>1 are returned as a 2d arrays.
resulting single Axes object is returned as a scalar.
- for Nx1 or 1xN subplots, the returned object is a 1D numpy
object array of Axes objects are returned as numpy 1D arrays.
- for NxM, subplots with N>1 and M>1 are returned as a 2D arrays.

- If False, no squeezing at all is done: the returned axis object is
always a 2-d array containing Axis instances, even if it ends up
- If False, no squeezing at all is done: the returned Axes object is
always a 2D array containing Axes instances, even if it ends up
being 1x1.

subplot_kw : dict, optional
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.