Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

DOC: fix radial increase of size & OO style in polar_scatter_demo #6688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2016

Conversation

afvincent
Copy link
Contributor

Should fix #6687

I also tweaked the header docstring to wrap it slightly before col. 79.

@afvincent afvincent added this to the 2.0.1 (next bug fix release) milestone Jul 4, 2016
@afvincent afvincent changed the title Fix radial increase of size & OO style DOC: fix radial increase of size & OO style in polar_scatter_demo Jul 4, 2016
@afvincent
Copy link
Contributor Author

Additional question because I've seen both in the example gallery: when using a colormap in an example, is it preferred to simply call plt.cm.*colormap_name* or to first import matplotlib.cm as cm and then call the colormap where it is needed with cm.*colormap_name*?

@NelleV
Copy link
Member

NelleV commented Jul 4, 2016

Both are fine. I have a slight preference for the latter, but it is personal.
Thanks for the patch!

@NelleV NelleV merged commit 5dfe000 into matplotlib:master Jul 4, 2016
@afvincent
Copy link
Contributor Author

@NelleV Thank you for the explanations about calling a colormap.

@afvincent afvincent deleted the fix_polar_scatter_demo branch July 5, 2016 07:30
QuLogic pushed a commit to QuLogic/matplotlib that referenced this pull request Oct 16, 2016
DOC: fix radial increase of size & OO style in polar_scatter_demo
@QuLogic
Copy link
Member

QuLogic commented Oct 16, 2016

Backported to v2.x via 70b851f.

@QuLogic QuLogic modified the milestones: 2.0.1 (next bug fix release), 2.0 (style change major release) Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small issues with the example polar_scatter_demo.py
4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.