Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Use subprocess32 on python 2.7 #6576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 12, 2016
Merged

Use subprocess32 on python 2.7 #6576

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2f94956
Depend on subprocess32 on posix systems for python27
jenshnielsen Jun 12, 2016
67d26aa
Remove no longer needed workaround for subprocess pre 2.7
jenshnielsen Jun 12, 2016
5accdc9
No longer relevant comment
jenshnielsen Jun 12, 2016
4b36ce4
Fix comments
jenshnielsen Jul 10, 2016
c4d126f
compat/subprocess is now pep8 complient
jenshnielsen Jul 12, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix comments
  • Loading branch information
@jenshnielsen
jenshnielsen committed Jul 11, 2016
commit 4b36ce4dd47674622e87b63370c4b45dc51199d6
1 change: 0 additions & 1 deletion 1 lib/matplotlib/compat/subprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
__all__ = ['Popen', 'PIPE', 'STDOUT', 'check_output', 'CalledProcessError']



if hasattr(subprocess, 'Popen'):
Popen = subprocess.Popen
# Assume that it also has the other constants.
Expand Down
8 changes: 4 additions & 4 deletions 8 setupext.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1386,8 +1386,8 @@ def check(self):
import functools32
except ImportError:
return (
"functools32 was not found. It is required for for"
"python versions prior to 3.2")
"functools32 was not found. It is required for"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you didn't mean to change this one and were looking for the double for in the subprocess32 package, but since you're here, it should say Python.

"Python versions prior to 3.2")

return "using functools32"
else:
Expand All @@ -1409,8 +1409,8 @@ def check(self):
import subprocess32
except ImportError:
return (
"subprocess was not found. It is an optional dependency"
" for for python versions prior to 3.2 that improves"
"subprocess32 was not found. It used "
" for Python versions prior to 3.2 to improves"
" functionality on Linux and OSX")

return "using subprocess32"
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.