Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Updating animation file writer to allow keywork arguments when using with construct #6304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 29, 2016
Merged

Updating animation file writer to allow keywork arguments when using with construct #6304

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
299f8af
Updated to allow keyword args to be passed when using the `with savin…
jmc734 Apr 14, 2016
4d8bcb8
Merge remote-tracking branch 'upstream/master'
jmc734 Apr 18, 2016
653e240
Removed arbitrary argument lists from setup()
jmc734 Apr 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions 8 lib/matplotlib/animation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ class AbstractMovieWriter(six.with_metaclass(abc.ABCMeta)):
'''

@abc.abstractmethod
def setup(self, fig, outfile, dpi, *args):
def setup(self, fig, outfile, dpi):
'''
Perform setup for writing the movie file.

Expand All @@ -163,13 +163,13 @@ def finish(self):
'Finish any processing for writing the movie.'

@contextlib.contextmanager
def saving(self, fig, outfile, dpi, *args):
def saving(self, fig, outfile, dpi, *args, **kwargs):
'''
Context manager to facilitate writing the movie file.

All arguments are passed on to `setup`.
'''
self.setup(fig, outfile, dpi, *args)
self.setup(fig, outfile, dpi, *args, **kwargs)
yield
self.finish()

Expand Down Expand Up @@ -246,7 +246,7 @@ def frame_size(self):
width_inches, height_inches = self.fig.get_size_inches()
return width_inches * self.dpi, height_inches * self.dpi

def setup(self, fig, outfile, dpi, *args):
def setup(self, fig, outfile, dpi):
'''
Perform setup for writing the movie file.

Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.