Mnt qt imports #6174
Merged
Mnt qt imports #6174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If PySide, PyQt4, or PyQt5 are imported do not consult rcparams or ENV variable to decide which backend to use. This is a case where ignoring user input is sensible because the Qt bindings are mutually exclusive and attempting to import a second binding will fail. This can result in stand-alone scripts / mpl embeddings which are dependent on the rcparams to function correctly. Importing a specific Qt binding is stronger signal of user intent that either of the other two configuration options and should take precedence. closes matplotlib#6164
A check was added change the fall-back behavior if the backend was not
set to PyQt{4,5}, but mpl was being embedded in a larger Qt application.
The previous commit handles the cases where Qt bindings are already
imported earlier in the module so the check here can be removed.
|
@jrevans Can you check that this does not break your use case? I think this is a better solution than what we are currently shipping with 1.5.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this is merged and the merge cascade gets this onto master a follow on PR to add a check for pyside2 is needed.