Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix gridspec.Gridspec: check ratios for consistency with rows and columns #5892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 24, 2016
Merged

Fix gridspec.Gridspec: check ratios for consistency with rows and columns #5892

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3783bf3
Check for consistent height and width ratios
julianvmodesto Jan 21, 2016
d1f0191
Reference issue #5835 in docstring
julianvmodesto Jan 21, 2016
9052785
Add tests for both height and width ratios
julianvmodesto Jan 23, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Reference issue #5835 in docstring
  • Loading branch information
@julianvmodesto
julianvmodesto committed Jan 21, 2016
commit d1f0191bfddbd07ebf50dab3f229cf5d525c771b
4 changes: 4 additions & 0 deletions 4 lib/matplotlib/tests/test_gridspec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,9 @@ def test_equal():


def test_ratios():
"""
Addresses issue #5835.
See at https://github.com/matplotlib/matplotlib/issues/5835.
"""
assert_raises(ValueError, gridspec.GridSpec,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a second one of these which fails via the other path (if I am reading this right this only really tests the width based failure).

1, 2, width_ratios=[2, 1, 3], height_ratios=[3, 4])
Morty Proxy This is a proxified and sanitized view of the page, visit original site.