-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Rewrite of image infrastructure #5718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
65 commits
Select commit
Hold shift + click to select a range
cf11aea
Remove Image class. Replace with resample func
mdboom 3b7d1bb
Agg backend shouldn't do its own image interp
mdboom c9cae50
Update interpolation_methods.py to use viridis
mdboom 4a05302
Remove svg.image_noscale rcParam
mdboom 0aa222a
Rewrite image classes
mdboom 0793aa2
Update backends for new API
mdboom 1384c7c
Use transforms to rotate image, not hack
mdboom 9148c7f
Update tests
mdboom 820479e
Decrease generated code size
mdboom fad84c8
Remove explicit LICENSE.
mdboom 64e84ea
Numpy 1.6 compatibility
mdboom 0be04c0
Add Agg filter test
mdboom a8643f1
Fix formatting
mdboom 5df79f0
Mark test as known fail on Numpy 1.6
mdboom b436f1a
Update draw_image API doc
mdboom dfbc39d
Fix reference counting
mdboom 9d3b468
[skip-ci] PEP8
mdboom f9d8534
Update what's new
mdboom 7b32cd8
Fix demo_annotation_box.py
mdboom 6e60ebf
Fix #3057: Don't composite when interpolation == 'none'
mdboom dc66ed0
Remove broken example
mdboom 7cccfb3
Support 16-bit grayscale
mdboom 5073f6e
Fix permissions on demo_image_affine.py
mdboom 625e80a
Fix alpha handling for interpolation == 'none'
mdboom c778cfc
Use `kind` instead of `issubclass`
mdboom 9fe6658
Update docstring
mdboom d61ac2a
Revert change
mdboom b3318fd
Make demo_text_path.py work again
mdboom ffbbf05
Remove extraneous space
mdboom fbb55c8
Privatize self._images
mdboom 34d6cc8
Simplify expression
mdboom 4c5a3bf
Update docstring
mdboom 9448208
Fix #5520: Don't round up if already rounded
mdboom 83f4bc9
Merge pull request #17 from tacaswell/image-interpolation
mdboom d5030a4
Use abs() for NEAREST check
mdboom 55c1abb
Image composite respecting z-order
mdboom fe376c4
Fix #4280: Preserve size when saving images
mdboom 5266fde
Python 2.x fix
mdboom 9285c3a
Update composite_images docstring
mdboom e2b2bbe
Refine can_composite
mdboom b894683
Improve make_image docstring
mdboom 4e43c8b
Use X.ndim over len(X.shape)
mdboom 8665697
Use float32 when applying alpha
mdboom d21a6ed
Use output.shape
mdboom 2d2a126
Add unsampled kwarg everywhere
mdboom 6d3518a
PEP8
mdboom 0b8d693
Use super()
mdboom 0f43f68
Put shape in exception
mdboom cd0e7e0
Case insensitive check for PNG extension
mdboom e62832f
Fix Numpy version check
mdboom e7d54d5
@cleanup unnecessary here
mdboom 3e532e1
Make BboxImage work
mdboom cfad8d9
Reinstate strictness of test_imsave_color_alpha
mdboom e52c26f
PEP8
mdboom 0469ab7
Fix has image test in Axes
mdboom b391f08
Refactor image compositing logic into a single function
mdboom 89365c1
Properly handle NULL composite image
mdboom 7f2f375
PEP8
mdboom 9827d1f
Consistent handling of empty composite images
mdboom 5be66de
Rename lena variable
mdboom bd521cd
Update docstring to reflect reality
mdboom d6b22a5
Address more minor comments in the PR
mdboom fff1d66
Increase tolerance on Windows
mdboom da6c00b
Increase tolerance of png_suite test
mdboom c9b2425
PEP8
mdboom File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add unsampled kwarg everywhere
- Loading branch information
commit 2d2a126baa8e2f015ed76304a043f15fc8ad6cf8
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this constructor be doing
super(PcolorImage, self).__init__(...)
? Right now, it is skipping theAxesImage
constructor even though that is its parent.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. This is something that I actually didn't change. I guess I'll update for
super
throughout this file.