Include outward ticks in bounding box #5683
Next
Next commit
Include outward ticks in bounding box
- Loading branch information
commit 46ae4d9794fef5437a66ad6fc21366201316ba0c
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -169,6 +169,21 @@ def apply_tickdir(self, tickdir): | |
| """ | ||
| pass | ||
|
|
||
| def get_tickdir(self): | ||
| return self._tickdir | ||
|
|
||
| def get_tick_padding(self): | ||
| """ | ||
| Get the length of the tick outside of the axes. | ||
| """ | ||
| tickdir = self._tickdir | ||
| if tickdir == 'in': | ||
|
There was a problem hiding this comment. bit of a bike shed, better to do this with a dictionary? |
||
| return 0.0 | ||
| elif tickdir == 'inout': | ||
| return self._size / 2 | ||
| elif tickdir == 'out': | ||
| return self._size | ||
|
|
||
| def get_children(self): | ||
| children = [self.tick1line, self.tick2line, | ||
| self.gridline, self.label1, self.label2] | ||
|
|
@@ -349,13 +364,11 @@ def apply_tickdir(self, tickdir): | |
|
|
||
| if self._tickdir == 'in': | ||
| self._tickmarkers = (mlines.TICKUP, mlines.TICKDOWN) | ||
| elif self._tickdir == 'inout': | ||
| self._tickmarkers = ('|', '|') | ||
| else: | ||
| self._tickmarkers = (mlines.TICKDOWN, mlines.TICKUP) | ||
| self._pad = self._base_pad + self.get_tick_padding() | ||
| self.stale = True | ||
|
|
||
| def _get_text1(self): | ||
|
|
@@ -485,13 +498,11 @@ def apply_tickdir(self, tickdir): | |
|
|
||
| if self._tickdir == 'in': | ||
| self._tickmarkers = (mlines.TICKRIGHT, mlines.TICKLEFT) | ||
| elif self._tickdir == 'inout': | ||
| self._tickmarkers = ('_', '_') | ||
| else: | ||
| self._tickmarkers = (mlines.TICKLEFT, mlines.TICKRIGHT) | ||
| self._pad = self._base_pad + self.get_tick_padding() | ||
| self.stale = True | ||
|
|
||
| # how far from the y axis line the right of the ticklabel are | ||
|
|
@@ -1067,7 +1078,7 @@ def _get_tick_bboxes(self, ticks, renderer): | |
| def get_tightbbox(self, renderer): | ||
| """ | ||
| Return a bounding box that encloses the axis. It only accounts | ||
| tick labels, axis label, offsetText and ticks themselves. | ||
| """ | ||
| if not self.get_visible(): | ||
| return | ||
|
|
@@ -1097,6 +1108,9 @@ def get_tightbbox(self, renderer): | |
| else: | ||
| return None | ||
|
|
||
| def get_tick_padding(self): | ||
| return self.majorTicks[0].get_tick_padding() | ||
|
There was a problem hiding this comment. should this be Never underestimate pathological users.... There was a problem hiding this comment. Another point: are we always guaranteed at least one tick? On Thu, Dec 17, 2015 at 11:59 AM, Michael Droettboom <
|
||
|
|
||
| @allow_rasterization | ||
| def draw(self, renderer, *args, **kwargs): | ||
| 'Draw the axis lines, grid lines, tick lines and labels' | ||
|
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this going to work for polar axes? I would also double-check that this doesn't utterly bork for axes3d (not that I'd expect it to work great there, just to not crash or something).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
polar axes don't have ticks -- but it does appear that this needs to be updated so it's aware of when the ticks are present or not.
It doesn't seem to crash for axes3d, though as you say, it doesn't really do the right thin other than add a bit more space.