ENH: when re-drawing the span clear previous span

Force a full re-draw on the last span is not in the blit background
matplotlib · mdboom · Dec 15, 2015 · Dec 15, 2015 · Dec 15, 2015 · Dec 15, 2015
commit a8934dcc74f6fd877bd95e1fff944e37033ee2ce
diff --git a/lib/matplotlib/widgets.py b/lib/matplotlib/widgets.py
@@ -1488,7 +1488,10 @@ def _press(self, event):
        self.rect.set_visible(self.visible)
        if self.span_stays:
            self.stay_rect.set_visible(False)
-
+            # really force a draw so that the stay rect is not in
+            # the blit background
+            if self.useblit:
+                self.canvas.draw()
        xdata, ydata = self._get_data(event)
        if self.direction == 'horizontal':
            self.pressv = xdata
-Original file line number
+Diff line change
@@ -1488,7 +1488,10 @@ def _press(self, event):
             self.rect.set_visible(self.visible)
             if self.span_stays:
                 self.stay_rect.set_visible(False)
+                # really force a draw so that the stay rect is not in
+                # the blit background
+                if self.useblit:
+                    self.canvas.draw()
             Copy link

  
      
    
  

  
      

  
  Member


      

  

  
    
      

      
            WeatherGod
  

      

      

      


        Dec 15, 2015


      
    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      but why is this necessary? Is this essentially forcing a remake of the background buffer? Should these events be responsible for triggering direct draw calls? Why can't this be deferred to later?
    
  
  


    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
      
  
    
    
      
        
            
    All reactions
  


          
          
        
      
    

    



    
        
  
    
        
    
  


      
          
  
      
            Copy link

  
      
    
  

  
      

  
  Member


      

  Author


  

  
    
      

      
            tacaswell
  

      

      

      


        Dec 15, 2015


      
    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      If the stay rectangle is present then the background that is grabbed will include it, by forcing the draw here it is removed from the background used for blitting.
    
  
  


    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
      
  
    
    
      
        
            
    All reactions
  


          
          
        
      
    

    



    
        
  
    
        
    
  


      
          
  
      
            Copy link

  
      
    
  

  
      

  
  Member


      

  

  
    
      

      
            WeatherGod
  

      

      

      


        Dec 15, 2015


      
    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      Why would the background include it? The artist has been set to be

invisible, thereby making things stale. Shouldn't it then remake the

background automatically at the next draw?
On Tue, Dec 15, 2015 at 11:33 AM, Thomas A Caswell <notifications@github.com

wrote:
In lib/matplotlib/widgets.py

#5681 (comment):

@@ -1487,7 +1488,10 @@ def _press(self, event):

self.rect.set_visible(self.visible)

if self.span_stays:
self.stay_rect.set_visible(False)


       # really force a draw so that the stay rect is not in



       # the blit background



       if self.useblit:



           self.canvas.draw()




If the stay rectangle is present then the background that is grabbed will

include it, by forcing the draw here it is removed from the background used

for blitting.
—

Reply to this email directly or view it on GitHub

https://github.com/matplotlib/matplotlib/pull/5681/files#r47660978.

    
  
  


    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
      
  
    
    
      
        
            
    All reactions
             xdata, ydata = self._get_data(event)
             if self.direction == 'horizontal':
                 self.pressv = xdata
-          Expand Down