Add new Vega colors as a ListedColormap #5678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There we go; though I forgot to add them to the colormap reference example. I'll do that after rebasing with the fixed build from #6020. |
|
Bumped now that build is working again. I don't think there are any colormap-specific tests that I need to worry about... |
tacaswell
added a commit
that referenced
this pull request
Feb 18, 2016
Add new Vega colors as a ListedColormap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #3973 is merged and the omnibus style changes are, we could add the Vega10 colors as a ListedColormap. (#3973 just provides a convenient way to do that).