Fix rubberband removal in Qt backend

matplotlib · tacaswell · Sep 1, 2015 · Aug 19, 2015 · Aug 20, 2015 · Aug 20, 2015
commit d27ad9832fbf59613b6fae5787323c6caa49d5ff
diff --git a/lib/matplotlib/backends/backend_qt5.py b/lib/matplotlib/backends/backend_qt5.py
@@ -681,6 +681,9 @@ def draw_rubberband(self, event, x0, y0, x1, y1):
        rect = [int(val)for val in (min(x0, x1), min(y0, y1), w, h)]
        self.canvas.drawRectangle(rect)

+    def remove_rubberband(self):
+        self.canvas.drawRectangle(None)
+
    def configure_subplots(self):
        image = os.path.join(matplotlib.rcParams['datapath'],
                             'images', 'matplotlib.png')

diff --git a/lib/matplotlib/backends/backend_qt5agg.py b/lib/matplotlib/backends/backend_qt5agg.py
@@ -67,7 +67,7 @@ def __init__(self, figure):

    def drawRectangle(self, rect):
        self._drawRect = rect
-        self.draw_idle()
+        self.update()

    def paintEvent(self, e):
        """
@@ -136,9 +136,14 @@ def paintEvent(self, e):
            pixmap = QtGui.QPixmap.fromImage(qImage)
            p = QtGui.QPainter(self)
            p.drawPixmap(QtCore.QPoint(l, self.renderer.height-t), pixmap)
+
+            # draw the zoom rectangle to the QPainter
+            if self._drawRect is not None:
+                p.setPen(QtGui.QPen(QtCore.Qt.black, 1, QtCore.Qt.DotLine))
+                x, y, w, h = self._drawRect
+                p.drawRect(x, y, w, h)
            p.end()
            self.blitbox = None
-        self._drawRect = None

    def draw(self):
        """