Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

allow fillstyle 'none' option #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 31, 2011
Prev Previous commit
Next Next commit
Merge branch 'master' from upstream into fillstyle_none.
Conflicts:
	lib/matplotlib/lines.py
	lib/matplotlib/markers.py
  • Loading branch information
cragm committed Dec 8, 2011
commit 9cff4e4d368f98ad68325785f199fd9ad4c1323b
4 changes: 3 additions & 1 deletion 4 lib/matplotlib/lines.py
Original file line number Diff line number Diff line change
Expand Up @@ -574,8 +574,10 @@ def get_marker(self): return self._marker.get_marker()
def get_markeredgecolor(self):
mec = self._markeredgecolor
if (is_string_like(mec) and mec == 'auto'):
if self._marker.get_marker() in ('.', ','):
return self._color
if self._marker.is_filled() and self.get_fillstyle() != 'none':
return 'k'
return 'k' # Bad hard-wired default...
else:
return self._color
else:
Expand Down
2 changes: 1 addition & 1 deletion 2 lib/matplotlib/markers.py
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ class MarkerStyle:
# is calculated in the _set_* functions.
filled_markers = (
'o', 'v', '^', '<', '>', '8', 's', 'p', '*', 'h', 'H', 'D', 'd')

fillstyles = ('full', 'left' , 'right' , 'bottom' , 'top', 'none')
_half_fillstyles = ('left' , 'right' , 'bottom' , 'top')

Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.
Morty Proxy This is a proxified and sanitized view of the page, visit original site.