Refactoring: fewer variables, slightly faster code #4226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code made me wonder why we had to use a variable that was used only once: I was wondering whether `get_figlabels()` had any side effect. Not only is the fact that this is not the case now explicit, but the code does not do any unnecessary call to `get_figlabels()` anymore.
tacaswell
added a commit
that referenced
this pull request
Mar 16, 2015
MNT : fewer variables, slightly faster code in fignum_exist
|
Thanks. Should probably deprecate and rename that function too..... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code made me wonder why we had to use a variable that was used only once: I was wondering whether
get_figlabels()had any side effect. Not only is the fact that this is not the case now explicit, but the code does not do any unnecessary call toget_figlabels()anymore.See the discussion at 0346946#commitcomment-10206373.