Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Code removal for post 1.5/2.1 #4128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 19, 2016
Merged

Conversation

tacaswell
Copy link
Member

No description provided.

@tacaswell
Copy link
Member Author

This is code that is slated to be removed in 1.6/2.2 or beyond.

@tacaswell tacaswell changed the title Code removal 2 Code removal for post 1.5/2.1 Feb 19, 2015

matplotlib.delaunay
-------------------
Remove the delaunay triangulation code which is now handled by QHull
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QHull should be Qhull.

@ianthomas23
Copy link
Member

Removal of delaunay looks good to me.

@tacaswell tacaswell force-pushed the code_removal_2 branch 2 times, most recently from a9614ef to 3009ead Compare April 19, 2015 17:34
@tacaswell tacaswell modified the milestones: next major release, unassigned Apr 19, 2015
@tacaswell
Copy link
Member Author

Addressed @ianthomas23 comment. Rebased so it merges, but this is still on-hold until until the next major release.

@tacaswell tacaswell modified the milestones: proposed next point release (2.1), next major release (2.0) Dec 14, 2015
@tacaswell
Copy link
Member Author

@ianthomas23 Can you have another look at this if you still remember anything about this deprecation?

@@ -203,7 +202,7 @@ def test_pep8_conformance_installed_files():
'tri/triinterpolate.py',
'tests/test_axes.py',
'tests/test_bbox_tight.py',
'tests/test_delaunay.py',
'tests/test_dviread.py',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why adding this? test_dviread.py is not even touched.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failed merge conflict resolution.


qt4_compat.py
-------------
Moved to ``qt_compat.py``. Renamed because in now handles Qt5 as well.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a small typo on this line: in -> it.

@ianthomas23
Copy link
Member

@tacaswell I am happy for the delaunay code to be removed asap, it has been
deprecated for long enough.

On 16 September 2016 at 06:09, Thomas A Caswell notifications@github.com
wrote:

@ianthomas23 https://github.com/ianthomas23 Can you have another look
at this if you still remember anything about this deprecation?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#4128 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAja5mrwF-gN2kTTk50MyUIinzhkHco-ks5qqiRwgaJpZM4Dieze
.

Deprecated in matplotlib#3174 / f896381

Fall out from the Qt5 upgrade PR matplotlib#3072 / b0dc1d5
@QuLogic QuLogic changed the title Code removal for post 1.5/2.1 [MRG+1] Code removal for post 1.5/2.1 Oct 19, 2016
@NelleV NelleV merged commit 179204c into matplotlib:master Oct 19, 2016
@QuLogic QuLogic changed the title [MRG+1] Code removal for post 1.5/2.1 Code removal for post 1.5/2.1 Oct 19, 2016
@tacaswell tacaswell deleted the code_removal_2 branch October 20, 2016 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.