-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Code removal for post 1.5/2.1 #4128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is code that is slated to be removed in 1.6/2.2 or beyond. |
|
||
matplotlib.delaunay | ||
------------------- | ||
Remove the delaunay triangulation code which is now handled by QHull |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QHull should be Qhull.
Removal of delaunay looks good to me. |
a9614ef
to
3009ead
Compare
Addressed @ianthomas23 comment. Rebased so it merges, but this is still on-hold until until the next major release. |
3009ead
to
ec5d206
Compare
@ianthomas23 Can you have another look at this if you still remember anything about this deprecation? |
@@ -203,7 +202,7 @@ def test_pep8_conformance_installed_files(): | ||
'tri/triinterpolate.py', | ||
'tests/test_axes.py', | ||
'tests/test_bbox_tight.py', | ||
'tests/test_delaunay.py', | ||
'tests/test_dviread.py', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why adding this? test_dviread.py
is not even touched.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
failed merge conflict resolution.
|
||
qt4_compat.py | ||
------------- | ||
Moved to ``qt_compat.py``. Renamed because in now handles Qt5 as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a small typo on this line: in -> it.
ec5d206
to
b00839f
Compare
@tacaswell I am happy for the delaunay code to be removed asap, it has been On 16 September 2016 at 06:09, Thomas A Caswell notifications@github.com
|
Removed in PR matplotlib#2504 merged to master as 6afba8d
Deprecated in matplotlib#3174 / f896381 Fall out from the Qt5 upgrade PR matplotlib#3072 / b0dc1d5
b00839f
to
801a133
Compare
No description provided.