-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Proof of Concept: Data Containers #30865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ksunden
wants to merge
18
commits into
matplotlib:main
Choose a base branch
from
ksunden:data_container_poc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not the full contianer I'd like, but easy fix to keep tests passing
Member
|
At this stage of draft, what in particular do you need feedback on? And can you provide a sketch/diagram of where/how this plays w/ the drawing stack? Also can this PR be broken up into the ArrayContainer and then the specialized containers separately? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this is intended for the Matplotlib 3.12 cycle, this will remain in draft until at least
we have branched off 3.11.x. There is a list of TODOs at the bottom, many of which I would
prefer to address before leaving draft anyway, but I may also decide some would be better as
unique follow-ons. In particular there are known test failures that do need addressing.
PR summary
Overview
This is part one of integrating the data prototype work into the main library.
The primary focus is on the actual Containers, rather than the other portion of the data prototype work, which is the transformation pipeline.
These two pieces are not entirely separable, as containers which do calculations do still use a light version of the latter, but custom edges are not yet exposed to users here.
Developer perspective
User perspective
set_containermethod added to the affected artist classesdescribeandquerympl_data_containersSome example code
Remaining TODOs: