Allow setting of aspect ratio for Axes in rcParams - Draft PR #30017
Conversation
|
I made a simple and basic implementation for this feature, before realising there was another draft request (#25642 ) open. Should I try to build off that Draft PR, or is my simple fix and ok starting point? |
There was a problem hiding this comment.
I'm only +0.1 on this. There's low need for it. A fixed aspect can never be part of a style because it only works reasonably when you know your data is in a similar aspect. I concede though, that it may be helpful on helper functions for custom plot types.
This should be introduced together with axes.adjustable.
This needs a "what's new entry - https://matplotlib.org/devdocs/users/next_whats_new/README.html
| @@ -680,7 +680,7 @@ def __init__(self, fig, | ||
| raise ValueError('Width and height specified must be non-negative') | ||
| self._originalPosition = self._position.frozen() | ||
| self.axes = self | ||
| self._aspect = 'auto' | ||
| self._aspect = None |
There was a problem hiding this comment.
| self._aspect = None | |
| self._aspect = mpl.rcParams['axes.aspect'] |
Resolution should happen at initialization.
| This is either "auto" or a float giving the ratio of y/x-scale. | ||
| This is either "auto", "equal" or a float giving the ratio of y/x-scale. | ||
| """ | ||
| return self._aspect | ||
| if self._aspect: | ||
| return self._aspect | ||
| aspect = mpl.rcParams['axes.aspect'] | ||
| return aspect if aspect != 'equal' else 1 |
There was a problem hiding this comment.
Let's not change anything here. rcParams lookup should be in __init__. Normalization "equal" -> 1 can be done in validate_aspect, so that "equal" is only public API but never internal state.
** DRAFT PR **
closes #8088
Implementing feature that allows the setting of a default aspect ratio for axes, not just images. New features involves the addition of the rcParam: axes.aspect.
Below is a screenshot showing the feature in action (before the last couple of recent upstream commits were merged into the branch):
