Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Backport PR #29908 on branch v3.10.x (TST: Use text placeholders for empty legends) #29935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v3.10.x
Choose a base branch
Loading
from

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #29908: TST: Use text placeholders for empty legends

@lumberbot-app lumberbot-app bot added this to the v3.10.2 milestone Apr 17, 2025
@rcomer rcomer closed this Apr 20, 2025
@rcomer rcomer reopened this Apr 20, 2025
@rcomer rcomer force-pushed the auto-backport-of-pr-29908-on-v3.10.x branch from 171d4a3 to 9637932 Compare April 20, 2025 17:46
@rcomer
Copy link
Member

rcomer commented Apr 20, 2025

Rebased 🤞

@rcomer
Copy link
Member

rcomer commented Apr 20, 2025

I have no idea why these tests are failing. The striped line test failure looks like

Expected
striped_line-expected

Actual
striped_line

Diff
striped_line-failed-diff

The legend seems genuinely slightly taller than in the reference.

@QuLogic
Copy link
Member

QuLogic commented Apr 22, 2025

Ah, this would need #29907, which wasn't backported.

@dstansby
Copy link
Member

dstansby commented Apr 24, 2025

What's the preferred solution here then - backport #29907 or just update the test image here?

@QuLogic
Copy link
Member

QuLogic commented Apr 25, 2025

If we're backporting #29816, then we should also do #29907, or else these images will be inconsistent between FreeType versions.

@ksunden
Copy link
Member

ksunden commented May 2, 2025

This is wrapped up in the freetype side of things, so not going to hold 3.10.2 on it (since we're not waiting on that for 3.10.2).

That said, may be worth getting all of these backported if we are going this route, which I think is the consensus (and my personal opinion).

@ksunden ksunden modified the milestones: v3.10.2, v3.10.3 May 2, 2025
@QuLogic
Copy link
Member

QuLogic commented May 6, 2025

I decided to start a backport of #29907. If people started using the text_placeholders fixture (probably unlikely, I'm sure), then we'd want the results to be right from the get go.

@QuLogic QuLogic force-pushed the auto-backport-of-pr-29908-on-v3.10.x branch from 9637932 to 89bfa2e Compare May 6, 2025 08:41
@timhoffm
Copy link
Member

timhoffm commented May 6, 2025

How much will we still backport to 3.10.x? If we don't need backports that add new test images or modify the existing ones, we could leave 3.10.x on the images with text. It should reach end-of-life in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.