-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
API: bump minimum supported version of Python and numpy #29904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://matplotlib.org/devdocs/devel/min_dep_policy.html#list-of-dependency-versions should also be updated
Optional: Maybe add a section there to list all places that needs updating so that we do not forget things (on average we'll have to do the bump once a year)
88dc305
to
57e410f
Compare
I violated the docs I added on how to do this by adding the docs on how to do this as part of the PR to do the bump. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's also at least one other 310 reference in cibuildwheel.yml
that I can't comment on directly here.
I was searching for 3.10 and missed 310 🤦🏻 . At least the auto-labeler worked and we got the cibulidwheel failures to catch it! Looks like pypy does not support py311 yet, but there is a beta version (https://pypy.org/posts/2025/02/pypy-v7319-release.html). Hopefully that will be released by the time we do a release. |
395fec9
to
27b3081
Compare
It looks like cibuildwheel does already support it! https://cibuildwheel.pypa.io/en/stable/options/ |
Hopefully this will also make Azure more stable as the py310 on windows seemed to have the most (but not all) of the subprocess communication timeout issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's one more file that needs updating when min numpy is update - sorry for missing this on first review.
Thank you far catching that @dstansby ! I had minver in both lists, decided I didn't want to put it in the Python bump for the comment and then apparently removed it in both places 🤦🏻 . |
3be8ffb
to
fd598f6
Compare
In accordance with our policy, the minimum supported Python for the next release will be Python 3.11. Co-authored-by: David Stansby <dstansby@gmail.com>
fd598f6
to
6958844
Compare
Co-authored-by: David Stansby <dstansby@gmail.com>
Co-authored-by: David Stansby <dstansby@gmail.com> Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
d6ccf11
to
4c435a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small typo.
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
In accordance with our policy, the minimum supported Python for the next release will be Python 3.11.