Added figsize and layout getters and setters for Figure.__init__ #29632
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
|
Thanks for the contribution. Unfortunately, the topic needs some API decisions before we can move forward (#24617 (comment)). I'm sorry this has not been communicated in the original issue. The discussions will happen in the respective issues
and I believe it's better to then do separte PRs on each, because it will be more than just adding the functions. |
PR summary
This fixes Add setter/getter methods for figsize and layout keyword parameters to Figure.init #24617
It adds getters and setters for :
figsize
layout
Code is cherry picked from #21549
"closes [ENH]: Add setter/getter methods for all keyword parameters to Figure.__init__ #24617 "
This is my first PR so I am unsure how testing works; help is greatly appreciated
As a newer dev, constructive criticism on my code, PR, or any other etiquette is also greatly appreciated