-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
DOC: Move "Infinite lines" example from section "pyplot" to "Lines, bars and markers #29622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me. On line 34 transform
could be changed to transform while you are in there. Either way, feel free to self-merge.
I do wonder if this belongs in annotations though. I think of infinite lines as annotating a plot versus representing data. It's too bad gallery entries cannot show up in two locations. |
I've also pondered where to put this. It's not clearly an existing category - if one would create a new I'd do something like "Decorations" but I don't think it's worth creating that category right now. I've decided against "Text, labels and annotations" because that section has a strong focus on text, and annotations there are something (often again a text) local next to a data point. Both concepts do not apply to infinite lines, and I did not want to add a new interpretation of "annotation" in. I've therefore gone with matching the pure type "line". No solution is optional here, but I believe it's good enough. |
I don't have any strong objections to it being here. I do think some of the things we do to annotate plots should be in the annotation section, but again, could be cross referenced. |
57efd40
to
1c01ee6
Compare
Tag it w/ it's secondary purpose? |
…ars and markers" Let's reduce the section "pyplot" to examples explicitly showcasing special approaches and features of `pyplot`. An example mainly explaining how to draw infinite lines should be in the "lines" subsection.
1c01ee6
to
ffcb1e0
Compare
… section "pyplot" to "Lines, bars and markers
… section "pyplot" to "Lines, bars and markers
Let's reduce the section "pyplot" to examples explicitly showcasing special approaches and features of
pyplot
. An example mainly explaining how to draw infinite lines should be in the "lines" subsection.