Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

DOC: Move "Infinite lines" example from section "pyplot" to "Lines, bars and markers #29622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

timhoffm
Copy link
Member

Let's reduce the section "pyplot" to examples explicitly showcasing special approaches and features of pyplot. An example mainly explaining how to draw infinite lines should be in the "lines" subsection.

@github-actions github-actions bot added the Documentation: examples files in galleries/examples label Feb 14, 2025
@timhoffm timhoffm added this to the v3.10.0-doc milestone Feb 14, 2025
Copy link
Member

@rcomer rcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. On line 34 transform could be changed to transform while you are in there. Either way, feel free to self-merge.

@jklymak
Copy link
Member

jklymak commented Feb 14, 2025

I do wonder if this belongs in annotations though. I think of infinite lines as annotating a plot versus representing data. It's too bad gallery entries cannot show up in two locations.

@timhoffm
Copy link
Member Author

I've also pondered where to put this. It's not clearly an existing category - if one would create a new I'd do something like "Decorations" but I don't think it's worth creating that category right now. I've decided against "Text, labels and annotations" because that section has a strong focus on text, and annotations there are something (often again a text) local next to a data point. Both concepts do not apply to infinite lines, and I did not want to add a new interpretation of "annotation" in. I've therefore gone with matching the pure type "line". No solution is optional here, but I believe it's good enough.

@jklymak
Copy link
Member

jklymak commented Feb 14, 2025

I don't have any strong objections to it being here. I do think some of the things we do to annotate plots should be in the annotation section, but again, could be cross referenced.

@story645
Copy link
Member

story645 commented Feb 14, 2025

It's too bad gallery entries cannot show up in two locations.

Tag it w/ it's secondary purpose? .. tag:: component:annotation or make a new label ..tags:: purpose: decorations though decorations that highlight information are usually annotations in visualization literature.

…ars and markers"

Let's reduce the section "pyplot" to examples explicitly showcasing special approaches and features of `pyplot`. An example mainly explaining how to draw infinite lines should be in the "lines" subsection.
@timhoffm timhoffm merged commit c7e286e into matplotlib:main Feb 14, 2025
22 checks passed
@timhoffm timhoffm deleted the doc-move-axline branch February 14, 2025 21:04
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Feb 14, 2025
… section "pyplot" to "Lines, bars and markers
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Feb 14, 2025
… section "pyplot" to "Lines, bars and markers
@ksunden ksunden mentioned this pull request Mar 3, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation: examples files in galleries/examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.