ci: Add an ARM Linux test workflow #29477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should probably skip some backends though; it seems PyQt5 doesnt have a wheel and is just stuck. |
tacaswell
reviewed
Jan 17, 2025
.github/workflows/tests.yml
Outdated
| echo 'PyQt5 is not available' | ||
| # PyQt5 does not have any wheels for ARM on Linux. | ||
| if [[ "${{ matrix.os }}" != 'ubuntu-20.04-arm' ]]; then | ||
| python -mpip install --upgrade pyqt5${{ matrix.pyqt5-ver }} && |
There was a problem hiding this comment.
Suggested change
| python -mpip install --upgrade pyqt5${{ matrix.pyqt5-ver }} && | |
| python -mpip install --upgrade pyqt5${{ matrix.pyqt5-ver }} --only-binary pyqt5 && |
The latest CI job seems like it is trying to build pyqt5 from an sdist still.
There was a problem hiding this comment.
Ah, I messed up the condition, but I've added this as well.
|
There are two failures:
|
Like the macOS jobs are mixed between Intel and ARM, this changes one of the Linux jobs to use ARM.
tacaswell
approved these changes
Jan 17, 2025
timhoffm
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Like the macOS jobs are mixed between Intel and ARM, this changes one of the Linux jobs to use ARM.
We'll see if we need to make any changes as in #24597 after the build is complete.
PR checklist