Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix title position for polar plots #29382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

rcomer
Copy link
Member

@rcomer rcomer commented Dec 27, 2024

PR summary

Fixes #29381 by partially reverting #28300. The problem was as described at #29381 (comment). We could potentially retain most of the performance gain from #28300 by adding a new return option (or two) to get_ticks_position. However, I am nervous about doing that in a micro release and propose to look at it as a follow up for v3.11. Note that this should not much affect the first and last performance gains outlined at #28300 (comment).

PR checklist

@rcomer rcomer added Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: polar PR: bugfix Pull requests that fix identified bugs labels Dec 27, 2024
@rcomer rcomer added this to the v3.10.1 milestone Dec 27, 2024
@@ -220,6 +220,21 @@ def test_polar_rlabel_position():
ax.tick_params(rotation='auto')


@mpl.style.context('default')
Copy link
Member Author

@rcomer rcomer Dec 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fails in classic mode. However it also fails in classic mode with v3.9.

output

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add an image comparison test that has polar titles? This seems like something we should check visually

@scottshambaugh scottshambaugh merged commit 86f089c into matplotlib:main Jan 6, 2025
39 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jan 6, 2025
QuLogic added a commit that referenced this pull request Jan 7, 2025
…382-on-v3.10.x

Backport PR #29382 on branch v3.10.x (Fix title position for polar plots)
@rcomer rcomer deleted the fix-polar-title branch January 7, 2025 08:23
@timhoffm timhoffm mentioned this pull request Jan 24, 2025
5 tasks
@ksunden ksunden mentioned this pull request Mar 3, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: bugfix Pull requests that fix identified bugs Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: axes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: title position incorrect for polar plot
3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.