Fix title position for polar plots #29382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcomer
commented
Dec 27, 2024
lib/matplotlib/tests/test_polar.py
Outdated
| @@ -220,6 +220,21 @@ def test_polar_rlabel_position(): | ||
| ax.tick_params(rotation='auto') | ||
|
|
||
|
|
||
| @mpl.style.context('default') |
There was a problem hiding this comment.
This fails in classic mode. However it also fails in classic mode with v3.9.
There was a problem hiding this comment.
Could you add an image comparison test that has polar titles? This seems like something we should check visually
9c32e5f to
604e2d8
Compare
timhoffm
approved these changes
Dec 28, 2024
604e2d8 to
6d0832d
Compare
scottshambaugh
approved these changes
Jan 6, 2025
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jan 6, 2025
QuLogic
added a commit
that referenced
this pull request
Jan 7, 2025
…382-on-v3.10.x Backport PR #29382 on branch v3.10.x (Fix title position for polar plots)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Fixes #29381 by partially reverting #28300. The problem was as described at #29381 (comment). We could potentially retain most of the performance gain from #28300 by adding a new return option (or two) to
get_ticks_position. However, I am nervous about doing that in a micro release and propose to look at it as a follow up for v3.11. Note that this should not much affect the first and last performance gains outlined at #28300 (comment).PR checklist