DOC / BUG: Fix savefig to GIF format with .gif suffix #29372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://matplotlib.org/stable/users/explain/figure/figure_intro.html#saving-figures: > Many types of output are supported, including raster formats like > PNG, GIF, JPEG, TIFF and vector formats like PDF, EPS, and SVG. However, GIF support was broken by matplotlib#6178. Restore GIF support.
tacaswell
reviewed
Dec 23, 2024
|
Test failure looks real, but I think it is due to our minimum verison of pillow being per 9.0 when the improved transparency + gif support was added. I'm going to open a PR to bump that (seems better to do the API change to bump the minimum version on its own). |
Co-authored-by: Thomas A Caswell <tcaswell@gmail.com>
|
"power cycled" to generate a new (synthetic) merge `ommit against main. |
tacaswell
approved these changes
Dec 23, 2024
QuLogic
reviewed
Jan 16, 2025
QuLogic
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
According to https://matplotlib.org/stable/users/explain/figure/figure_intro.html#saving-figures:
However, GIF support was broken by #6178. Restore GIF support.
PR checklist