-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Apply some modernization to C++ extensions #29280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d53cd7f
to
25aa8f5
Compare
ianthomas23
requested changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've checked this all and everything is fine except for the one nit.
Also use `auto` and structured binding for iterators. This is based on running `clang-tidy` with the `modernize-loop-convert` and `modernize-use-auto` checks. Note though that I did not (yet) apply any `auto` suggestions that were not `for` loops.
This uses clang-tidy's `modernize-use-nullptr` check.
With `emplace_back`, we don't need to create an object ourselves, to be copied into the container, plus it returns a reference to the new object for us to use. This used clang-tidy's `modernize-use-emplace` check, plus some followups to use the return values.
This is applying clang-tidy's `modernize-use-equals-default` and `modernize-use-equals-delete` checks.
This applies clang-tidy's `modernize-type-traits` check.
25aa8f5
to
86321df
Compare
ianthomas23
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved assuming CI passes.
WeatherGod
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
As we are now on C++17, this applies some of the modernization checks from
clang-tidy
, namely:modernize-loop-convert
andmodernize-use-auto
(but only applied to loops)modernize-use-nullptr
modernize-use-emplace
modernize-use-equals-default
andmodernize-use-equals-delete
modernize-type-traits
PR checklist