TST: Run macosx backends in a subprocess #29150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the macosx backend, `event_loop_is_running` returns true after `lazy_init` is called, which happens in the `new` constructor for _any_ class. This means it is "running" as soon as a figure is created, and this will block any other backend tests.
27f2170 to
c97d30d
Compare
|
I can no longer find the text "Cannot load backend '...' which requires the '...' interactive framework, as 'macosx' is currently running." on the macOS runners, so this has correctly freed up the event loop to run other backends (though they may be skipped anyway for other reasons). |
ianthomas23
approved these changes
Nov 18, 2024
greglucas
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
While evaluating CI usage, I noticed that some backend tests were not running because the macosx event loop was already running.
In the macosx backend,
event_loop_is_runningreturns true afterlazy_initis called, which happens in thenewconstructor for any class. This means it is "running" as soon as a figure is created, and this will block any other backend tests.Not fully tested since I'm not on a mac, but we'll see how CI feels about it.
PR checklist