Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

DOC: Document preferred figure size for examples #29017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

timhoffm
Copy link
Member

No description provided.

@github-actions github-actions bot added the Documentation: devdocs files in doc/devel label Oct 24, 2024
doc/devel/document.rst Outdated Show resolved Hide resolved
Figure size
^^^^^^^^^^^
The default figure size is suitable in many cases. If you want to use an explicit
figure size, it should be chosen so that the figure is not wider than the available
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say "it should usually be chosen...". Sometimes downscaling is fine and it can save having to resize all the elements.

Also px is a fragile measure and possibly will lead to confusion when the doc build produces images that are 1440 px wide. How is the width of pydata sphinx theme specified?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that in browser-land "px" is always virtual screen pixels that are mostly stable and the what you want so hidpi is handled.

As much as I love details, maybe something like "do not go above 7.2in wide, which is the maximum size that will not be down-scaled in the rendered html documentation, without good reason"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried to condense the text, but feel the additional information is valuable
(i) reason for current numbers = pydata-sphinx-theme - the numbers may become incorrect if pydata-sphinx-theme changes, and it's easier to understand/update when we know where they came from
(ii) give px and figsize - I believe very few people think in inches nowadays.
(iii) give the "extended" width when there is not right-hand side menu - this can help people who actually need more space to still fit without downsampling.

doc/devel/document.rst Outdated Show resolved Hide resolved
@QuLogic QuLogic merged commit e8654e1 into matplotlib:main Oct 31, 2024
22 checks passed
@QuLogic QuLogic added this to the v3.10.0 milestone Oct 31, 2024
@timhoffm timhoffm deleted the doc-figure-size branch October 31, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation: devdocs files in doc/devel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.