FIX: auto_fmtxdate for constrained layout #29013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e1ed545 to
25fbacb
Compare
25fbacb to
0cf4c2f
Compare
|
PS no idea why Mypy test isn't working. Don't think it's on my end, but happy to fix something if needed. |
timhoffm
approved these changes
Oct 24, 2024
greglucas
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29011
figure.automft_xdateis a bit of a weird method, that labels outer labels on a subplotgrid in a figure and turns the labels 30 degrees (or more).However, before this PR it only did so if all the axes on the figure had a subplotspec.
By default, colorbars have a subplotspec, so old layout managers worked fine. However, colorbars in constrained layout are not created with a subplotspec (
colorbar(usegridspec=False)), so autofmt_xdate would not do anything.This just checks if an axes is labeled with '' or not, and if so, ignores if for the sake of determining if autofmt_xdate can work or not. It also doesn't try to do suplots_adjust if the engine is constrained layout as that is incompatible.