Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

patheffects.SimpleLineShadow calling non-existent get_foreground method from GraphicsContextBase #28814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
Loading
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion 2 lib/matplotlib/patheffects.py
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@
gc0.copy_properties(gc)

if self._shadow_color is None:
r, g, b = (gc0.get_foreground() or (1., 1., 1.))[:3]
r, g, b = (gc0.get_rgb() or (1., 1., 1.))[:3]

Check warning on line 328 in lib/matplotlib/patheffects.py

View check run for this annotation

Codecov / codecov/patch

lib/matplotlib/patheffects.py#L328

Added line #L328 was not covered by tests
# Scale the colors by a factor to improve the shadow effect.
shadow_rgbFace = (r * self._rho, g * self._rho, b * self._rho)
else:
Expand Down
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.