Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Added documentation for parameters vmin and vmax inside specgram function. #28613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 31, 2024
Merged

Added documentation for parameters vmin and vmax inside specgram function. #28613

merged 2 commits into from
Jul 31, 2024

Conversation

Alsosa
Copy link
Contributor

@Alsosa Alsosa commented Jul 24, 2024

PR summary

Parameters vmin and vmax are not documented inside specgram function.
Issue: #28548

PR checklist

github-actions[bot]
github-actions bot reviewed Jul 24, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@ksunden
Copy link
Member

ksunden commented Jul 24, 2024

Please do not run autoformatters on our code, they cause a lot of unrelated changes that make it quite hard to tell what is actually changing in this PR.

We intentionally do not run black (or ruff-format, autopep8, etc) because of the scale of change to our codebase.

Please revert that change and apply only the actual change you are looking to make.

@Alsosa Alsosa force-pushed the doc-vmin-vmax-in-specgram branch from ffadb37 to 4308782 Compare July 26, 2024 07:16
timhoffm
timhoffm reviewed Jul 29, 2024
View reviewed changes
lib/matplotlib/axes/_axes.py Outdated Show resolved Hide resolved
@Alsosa @timhoffm
Update lib/matplotlib/axes/_axes.py
fecf60a 
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
@timhoffm timhoffm merged commit 8e9c478 into matplotlib:main Jul 31, 2024
35 of 37 checks passed
@timhoffm
Copy link
Member

Thanks @Alsosa!

@QuLogic QuLogic added this to the v3.10.0 milestone Jul 31, 2024
@Alsosa Alsosa deleted the doc-vmin-vmax-in-specgram branch July 31, 2024 13:50
@rcomer rcomer mentioned this pull request Aug 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
First Time Contributors
Status: Merged
Milestone
v3.10.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Alsosa @ksunden @timhoffm @QuLogic @melissawm
Morty Proxy This is a proxified and sanitized view of the page, visit original site.