TYP: Fix xycoords and friends #28532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the convention is for type aliases/unions to be named like classes (i.e. CamelCase), since they are taking the place of a class as a type hint. Further, my preference would be to put it with other union definitions in |
|
Thanks for the ping. I can get to this today. |
|
I think I've updated this based on the comments, and it's ready for another look. |
timhoffm
approved these changes
Sep 16, 2024
ksunden
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
The existing type definition for
xycoords(and friends) only support passing a tuple of floats, where in fact a tuple of anything that is valid on its own is acceptable. The easiest way to define this is with type variables, which I then reused everywhere.I defined this based on the docs here, not really from reading the code, for what it's worth.
PR checklist